fix: ensure floating UI has loaded before using its functions#560
Merged
fix: ensure floating UI has loaded before using its functions#560
Conversation
🦋 Changeset detectedLatest commit: c93cf2a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agliga
approved these changes
Mar 11, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents calls into Floating UI APIs before the library has finished loading, avoiding runtime errors (notably in JSDom environments) when tooltip/dropdown positioning updates run too early.
Changes:
- Guard
TooltipBase.updateTip()so it no-ops until Floating UI has loaded. - Guard
DropdownUtil.update()so it no-ops until Floating UI has loaded.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/ebayui-core/src/components/components/ebay-tooltip-base/component-browser.ts | Adds a loaded-state guard before calling computePosition in tooltip positioning updates. |
| packages/ebayui-core/src/common/dropdown/index.ts | Adds a loaded-state guard before building middleware and calling computePosition in dropdown positioning updates. |
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure floating UI has loaded before we try to use its functions. This was causing issues with some JSDom tests